On Thu, Aug 30, 2012 at 10:07:06AM +0900, Simon Horman wrote: > On Wed, Aug 29, 2012 at 10:48:00AM -0700, Ben Pfaff wrote: > > On Tue, Aug 21, 2012 at 01:55:42PM +0900, Simon Horman wrote: > > > Signed-off-by: Simon Horman <[email protected]> > > > > Passing the "struct netdev_stats" to append_port_stat10() and > > append_port_stat11() by value, rather than through a pointer, looks > > needlessly inefficient to me (although possibly GCC optimizes this > > out). I'd prefer to use a pointer. > > Thanks. I'm unsure why I chose to pass by value.
I guessed that you wanted the patch to be smaller since passing through a pointer requires lots of "." => "->" changes. But I'd rather have the pointer even if it needs a little churn. _______________________________________________ dev mailing list [email protected] http://openvswitch.org/mailman/listinfo/dev
