On Wed, Dec 19, 2012 at 10:11 PM, Ethan Jackson <et...@nicira.com> wrote: > diff --git a/lib/netdev-linux.c b/lib/netdev-linux.c > index d9a444b..c8d636a 100644 > --- a/lib/netdev-linux.c > +++ b/lib/netdev-linux.c > +static int > +netdev_internal_set_stats(struct netdev *netdev, > + const struct netdev_stats *stats) > +{ > + struct ovs_vport_stats rtnl_stats;
I would probably use a name other than rtnl_stats since they aren't actually that. The name must have gotten carried around for a while. Otherwise it seems fine (the split between dpif-linux, netdev-linux, and, netdev-vport is pretty awkward in general though). _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev