> We've already marked PMTUD as being deprecated and are planning on
> removing it on master. At the very least, before we apply this patch
> we should remove the ability to turn it on from userspace (it's
> already off by default). Ideally, we would also fully remove both it
> and the ability to set MAC addresses through the vport layer since
> both will be completely dead code. However, that part doesn't
> necessarily have to happen before this patch.
All of this sounds pretty reasonable. Do we really want to remove PMTUD
right now? According to the code, we're going to wait until February.
Alternatively, we could drop this patch for now, and reintroduce it when
we introduce flow based tunneling. At that time we'll have to solve both
problems. I don't feel strongly either way, thoughts?
Ethan
> > diff --git a/lib/netdev-vport.c b/lib/netdev-vport.c
> > index e50103b..a527f91 100644
> > --- a/lib/netdev-vport.c
> > +++ b/lib/netdev-vport.c
> > @@ -56,6 +56,7 @@ struct netdev_dev_vport {
> > struct netdev_dev netdev_dev;
> > struct ofpbuf *options;
> > unsigned int change_seq;
> > + uint8_t ea[ETH_ADDR_LEN];
>
> Can you use a name that is slightly more descriptive than 'ea'? I
> think there isn't necessarily enough context for the meaning to be
> obvious.
>
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
