> This isn't a new problem but I'm not sure that this operation is safe > if you run this immediately after creating a port because options is > NULL. We probably either need to fetch the options (which is what we > do for unparse) or handle NULL as an empty set better. >
Agreed. This is only used to set the tunnel_egress_iface, which isn't particularly important. I think for now, simply doing nothing if 'options' is missing should be fine. I think that belongs in it's own patch though. Your other comments make sense, I'll send out a new version. Ethan
_______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
