> On Jul 29, 2016, at 12:43 PM, Ben Pfaff <b...@ovn.org> wrote: > > On Thu, Jul 28, 2016 at 11:26:18PM -0700, Justin Pettit wrote: >> Introduce the "flags.loopback" symbol to allow packets to be sent back >> on their ingress ports. Previously, one needed to clear "inport" to >> hair-pin packets, but this made "inport" not available for future >> matching. This approach should be more intuitive, but it will also be >> needed in future patches. >> >> This patch also removes functionality from the OVN expression library >> that clears the OpenFlow ingress port when the logical input port is >> zeroed. >> >> Signed-off-by: Justin Pettit <jpet...@ovn.org> > > I found the description of OpenFlow table 64 in ovn-architecture(7) to > be somewhat confusing. Here's a rewrite: > > <p> > Table 64 bypasses OpenFlow loopback when MLF_ALLOW_LOOPBACK is set. > Logical loopback was handled in table 34, but OpenFlow by default also > prevents loopback to the OpenFlow ingress port. Thus, when > MLF_ALLOW_LOOPBACK is set, OpenFlow table 64 saves the OpenFlow ingress > port, sets it to zero, resubmits to table 65 for logical-to-physical > transformation, and then restores the OpenFlow ingress port, > effectively disabling OpenFlow loopback prevents. When > MLF_ALLOW_LOOPBACK is unset, table 64 flow simply resubmits to table > 65. > </p>
Sounds good. Thanks for suggesting text. > Also, I think that tables 64 and 65 should be in different <li>...</li> > blocks instead of the same one. I went back and forth on that. Thanks for making a decision. > Acked-by: Ben Pfaff <b...@ovn.org> Thanks. --Justin _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
