> On Aug 1, 2016, at 12:17 AM, Ben Pfaff <b...@ovn.org> wrote:
>
> On Mon, Aug 01, 2016 at 12:12:17AM -0500, Justin Pettit wrote:
>>
>>> On Jul 29, 2016, at 12:46 PM, Ben Pfaff <b...@ovn.org> wrote:
>>>
>>> On Thu, Jul 28, 2016 at 11:26:19PM -0700, Justin Pettit wrote:
>>>> Every IPv6-enabled interface is supposed to have a link-local address
>>>> available to it. This commit adds a link local interface to each router
>>>> port and scopes link-local routes to the ingress port that received the
>>>> packet.
>>>>
>>>> Signed-off-by: Justin Pettit <jpet...@ovn.org>
>>>
>>> In add_route() in ovn-northd.c, I don't think that it's ideal to use a
>>> string comparison to compare an IPv6 address:
>>> + struct ds match = DS_EMPTY_INITIALIZER;
>>> + if (!strcmp("fe80::", network_s) && plen == 64) {
>>
>> Fair point. How about the incremental at the end?
>
> The bits->string->bits thing is also weird, but oh well.
Agreed. As we discussed off-line, this would require making the arguments to
add_route() even more unwieldy. As we also discussed, ovn-northd is in need of
refactoring since it's not going to scale long-term (both in terms of it
currently doing unnecessary recalculations and code maintainability as we add
more functionality).
--Justin
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
