the question is whether this is a heavy regression or whether we can defer this to 1.2.6... Given that 1.2.4 worked and we only fixed a few bugs I'd let it run.
LieGrue, strub > On Saturday, 24 May 2014, 22:23, Joseph Bergmark <[email protected]> wrote: > > No problem, I've opened a JIRA issue and attached a patch that resolves the > issue in my testing. > > > > On Sat, May 24, 2014 at 3:57 PM, Mark Struberg <[email protected]> wrote: > >> >> >> Hi Joe! >> >> Thanks for checking. I'll try to reproduce tonight or tomorrow and will >> abort the VOTE if I can reproduce it. >> >> txs and LieGrue, >> strub >> >> >> > On Saturday, 24 May 2014, 21:22, Joseph Bergmark > <[email protected]> >> wrote: >> > > I walked though the code in debug, and from what I can tell it > appears >> to >> > be an issue with the way the URLs are being generated (at least on my >> > machine). >> > >> > My breakpoints in AbstractMetaDataDiscovery & CdiArchive are > showing URLs >> > for my classes directory that look like: >> > file:file:/C:/workspaces/owb-1.2.5/samples/guess/target/classes/ >> > >> > WebScannerService createURLFromMarkerFile has what appears to be a >> correct >> > String > "file:/C:/workspaces/owb-1.2.5/samples/guess/target/classes/" >> > from >> > findBeansXmlBases, but it prepends "file:" again here on > line 156: >> > >> > //X TODO check! >> > addPath = "file:" + url + >> > "META-INF/beans.xml"; >> > >> > OWB-953 changed this class so that addPath is what is added to the > list >> of >> > URLs as previously it used url, so it is possible this is a small >> > regression for non-jar based URLs in web modules. >> > >> > >> > >> > On Sat, May 24, 2014 at 2:47 PM, Gerhard Petracek < >> > [email protected]> wrote: >> > >> >> i've upgraded several projects to v1.2.5 (e.g. [1] and [2]) > and all >> > tests >> >> look fine. >> >> -> +1 >> >> >> >> regards, >> >> gerhard >> >> >> >> [1] https://github.com/CDIatWork/IdeaFork >> >> [2] >> >> >> >> >> > >> > https://git-wip-us.apache.org/repos/asf/deltaspike/repo?p=deltaspike.git;a=summary >> >> >> >> >> >> >> >> 2014-05-24 20:24 GMT+02:00 Joseph Bergmark > <[email protected]>: >> >> >> >> > I set up my build environment on a new machine, so its > possible >> > I'm >> >> > fighting a configuration problem, but after a successful > build from >> > the >> >> > 1.2.5 source zip, I'm having trouble with the guess > sample app >> > which is >> >> my >> >> > normal go-to for quick testing. >> >> > >> >> > It looks like an EL or bean discovery problem, as loginBean > isn't >> > being >> >> > found. I'll do a bit more digging but was curious if > anyone had >> > luck >> >> with >> >> > the samples or the guess sample app in particular. >> >> > >> >> > >> >> > On Sat, May 24, 2014 at 1:42 PM, David Blevins >> > <[email protected] >> >> > >wrote: >> >> > >> >> > > +1 >> >> > > >> >> > > >> >> > > -- >> >> > > David Blevins >> >> > > http://twitter.com/dblevins >> >> > > http://www.tomitribe.com >> >> > > >> >> > > On May 23, 2014, at 10:43 AM, Mark Struberg >> > <[email protected]> wrote: >> >> > > >> >> > > > >> >> > > > I'd like to call a VOTE on releasing Apache >> > OpenWebBeans-1.2.5 . >> >> > > > >> >> > > > This is a maintenance release of the owb_1.2.x > branch and >> > targets the >> >> > > CDI-1.0 specification. >> >> > > > >> >> > > > The ReleaseNotes are available online: >> >> > > > >> >> > > >> >> > >> >> >> > >> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310844&version=12326814 >> >> > > > >> >> > > > Maven staging repo: >> >> > > > >> >> > > >> >> > >> >> >> > >> > https://repository.apache.org/content/repositories/orgapacheopenwebbeans-1004/ >> >> > > > >> >> > > > >> >> > > > SVN source tag: >> >> > > > >> >> > > > >> >> > https://svn.apache.org/repos/asf/openwebbeans/tags/openwebbeans-1.2.5/ >> >> > > > >> >> > > > >> >> > > > Source Release: >> >> > > > >> >> > > >> >> > >> >> >> > >> > http://repository.apache.org/content/repositories/orgapacheopenwebbeans-1004/org/apache/openwebbeans/openwebbeans/1.2.5/openwebbeans-1.2.5-source-release.zip >> >> > > > >> >> > > > >> >> > > > Binary release: >> >> > > > >> >> > > > >> >> > > >> >> > >> >> >> > >> > http://repository.apache.org/content/repositories/orgapacheopenwebbeans-1004/org/apache/openwebbeans/openwebbeans-distribution/1.2.5/openwebbeans-distribution-1.2.5-binary.zip >> >> > > > >> >> > > > >> >> > > > PGP release key 2FDB81B1 >> >> > > > >> >> > > > > http://svn.apache.org/repos/asf/openwebbeans/trunk/KEYS >> >> > > > >> >> > > > >> >> > > > >> >> > > > The VOTE will be open for 72 hours. >> >> > > > [ ] +1 approve >> >> > > > [ ] +0 no opinion >> >> > > > [ ] -1 veto (and reason why) >> >> > > > >> >> > > > >> >> > > > >> >> > > > Here is my +1 >> >> > > > >> >> > > > >> >> > > > LieGrue, >> >> > > > strub >> >> > > >> >> > > >> >> > >> >> >> > >> >
