[
https://issues.apache.org/jira/browse/OWB-1293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16887850#comment-16887850
]
Greg Wilkins commented on OWB-1293:
-----------------------------------
In [https://github.com/eclipse/jetty.project/pull/3838] I'm now proposing that
we provide both mechanisms: the DecoratingListener will be available from the
decorate module and will allow any webapp to do decoration (with or without
CDI). I believe Weld will integrate using this. I will also provide the
CdiDecorator class that uses the CDI SPI and is activated by the cdi module.
However, I not yet got this to work with OWB and would appreciate help. If you
could contribute a small test webapp that would be perfect (as I have renamed
our test-cdi-webapp to test-weld-cdi-webapp to make space for a
test-owb-cdi-webapp). I have to pass review from my team.. so not sure if both
mechanism will survive that, so my preference is still that you talk with Weld
and come up with a single integration strategy.
Also, to avoid integration issues, you current integration should be updated to
check to see what integration options are available. If the
"org.eclipse.jetty.cdi" attribute is set to "CdiDecorator", then Option B is
enabled and no further work is necessary in OWB (once you fix whatever I've
done wrong). If "org.eclipse.jetty.webapp.DecoratingListener" is set, then it
is an attribute name that can be used with option B. Else use the old
integration APIs which will be enabled with the cdi2 module (but may not be
portable to jetty 10).
> Update Jetty integration prior to Jetty-10 release
> --------------------------------------------------
>
> Key: OWB-1293
> URL: https://issues.apache.org/jira/browse/OWB-1293
> Project: OpenWebBeans
> Issue Type: Improvement
> Components: Interceptor and Decorators
> Reporter: Greg Wilkins
> Priority: Major
>
> The current jetty integration relies on exposing private jetty APIs so a
> jetty Decorator can be registered. This is fragile and requires different
> APIs for the upcoming jetty-10 release.
> Instead, Jetty is developing a mechanism where a object with a decorator
> signature can be set as a context attribute and it will be introspected and
> dynamically registered as a decorator without any API dependencies.
> This is currently being developed in
> [https://github.com/eclipse/jetty.project/pull/3838] and an integration with
> Weld is at [https://github.com/weld/core/pull/1926]
> Feedback is sought from the OpenWebBeans team on the approach and then we'd
> like to collaborate to make a similar integration.
>
>
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
