[
https://issues.apache.org/jira/browse/OWB-1293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16887956#comment-16887956
]
Romain Manni-Bucau commented on OWB-1293:
-----------------------------------------
No real blocker, it just handles very few cases of an integration (typically
there is no overlap with openwebbeans-tomcat current usage whereas it can sound
like it would just be the same on jetty side).
{quote}the CDI integration code is in hands of the CDI impl
{quote}
This is one of the drawback I see, jetty is not able to support CDI but relies
on impls supporting jetty at the end which is bad since it prevents users to
just use CDI, they must use the jetty version supported by the impl.
{quote} * The CDI-related code resting in CDI impl also gives bigger assurance
to users that should something go wrong, there will be people around who
understand CDI and can solve it{quote}
Not a point IMHO since you can also reverse it and say the jetty side of things
will be a pity in the CDI land so it is a 1-1 here IMHO.
{quote}Servlet spec can adapt such approach
{quote}
CDI already did most of the work (the not portable layer is only a listener)
and Servlet spec already rejected part of it so let's disagree on this one even
if it sounds easy to defer the responsability to its sibling ;).
{quote}Jetty doesn't need to implement cumbersome class loading and reflection
based invocation of methods
{quote}
This is really 3 lines (1 try/catch with a single loadClass and could even just
be nothing if you replace by it the doc of the listener to add). Most of the
reflection is needed to support server/webapp provider approaches but this
sounds out of scope for jetty (whereas it is for tomcat to link to my first
sentence).
So at the end both options work and if you add the stability of the projects it
is likely that jetty is saner in terms of maintenance, now we are in the IT
side of things so everything works ;).
> Update Jetty integration prior to Jetty-10 release
> --------------------------------------------------
>
> Key: OWB-1293
> URL: https://issues.apache.org/jira/browse/OWB-1293
> Project: OpenWebBeans
> Issue Type: Improvement
> Components: Interceptor and Decorators
> Reporter: Greg Wilkins
> Priority: Major
>
> The current jetty integration relies on exposing private jetty APIs so a
> jetty Decorator can be registered. This is fragile and requires different
> APIs for the upcoming jetty-10 release.
> Instead, Jetty is developing a mechanism where a object with a decorator
> signature can be set as a context attribute and it will be introspected and
> dynamically registered as a decorator without any API dependencies.
> This is currently being developed in
> [https://github.com/eclipse/jetty.project/pull/3838] and an integration with
> Weld is at [https://github.com/weld/core/pull/1926]
> Feedback is sought from the OpenWebBeans team on the approach and then we'd
> like to collaborate to make a similar integration.
>
>
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
