philippkunz commented on a change in pull request #28:
URL: https://github.com/apache/openwebbeans/pull/28#discussion_r439806838



##########
File path: webbeans-junit5/src/main/java/org/apache/openwebbeans/junit5/Cdi.java
##########
@@ -80,6 +80,11 @@
      */
     boolean disableDiscovery() default false;
 
+    /**
+     * @return {@code true} to enable JUnit parameter resolution with CDI 
beans or {@code false} otherwise.
+     */
+    boolean injectParameters() default true;

Review comment:
       Although I can see the case in a theoretical sense, I have some 
difficulty to imagine a real situation where another approach would not 
sufficiently help such as setting `Cdi(disableDiscovery = true)` or listing 
fewer classes in `@Cdi(classes = ...)` or first of all working with CDI stuff 
(types, qualifiers, scopes, or `bean-discovery-mode`) or moving the parameter 
to an `@Inject`-annotated class variable to prevent Cdi to inject such a 
parameter that should be resolved by another extension.
   On the other hand such an annotation to tell Cdi not to resolve a parameter 
would not do any harm either. In fact, that way the discussion about 
`getParent` can be worked around.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to