rmannibucau commented on a change in pull request #28:
URL: https://github.com/apache/openwebbeans/pull/28#discussion_r439812619
##########
File path: webbeans-junit5/src/main/java/org/apache/openwebbeans/junit5/Cdi.java
##########
@@ -80,6 +81,15 @@
*/
boolean disableDiscovery() default false;
+ /**
+ * When present on a test method parameter, it will <em>not</em> be
attempted to be resolved with a CDI bean.
+ */
+ @Target(PARAMETER)
Review comment:
About qualifier point, this could be one to make the injection
unresolved and therefore handled by another extension.
This also means any custom qualifier can make it so maybe we just need to
document it in our doc that if an injection parameter is ambiguous/abusively
taken by cdi extension, adding an unresolved qualifier solves it.
This makes your global toggle relevant.
Do you prefer this option?
Another option is to not do it in cdi extension but in another junit ext
@CdiParameterInjections which uses CDI to impl it. This way both are composable.
We can even do a junit5 stereotype combining both
@CdiWithParameterInjections.
Sounds more modulable this way and avoids an useless coupling.
Wdyt?
(Still thinking to the smoothest option).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
