philippkunz commented on a change in pull request #28:
URL: https://github.com/apache/openwebbeans/pull/28#discussion_r439810136
##########
File path: webbeans-junit5/src/main/java/org/apache/openwebbeans/junit5/Cdi.java
##########
@@ -80,6 +80,11 @@
*/
boolean disableDiscovery() default false;
+ /**
+ * @return {@code true} to enable JUnit parameter resolution with CDI
beans or {@code false} otherwise.
+ */
+ boolean injectParameters() default true;
Review comment:
When you write qualifier, do you mean CDI `@Qualifier` specifically?
Like this?
```
@Qualifier
@Target({ TYPE, METHOD, PARAMETER, FIELD })
@Retention(RUNTIME)
@Documented
public @interface NotResolvedAsCdiBeanIntoJunitParameter {
}
```
and then
```
@Test void someTest(@NotResolvedAsCdiBeanIntoJunitParameter MyService
service) {
}
```
and not having any or no otherwise eligible bean class annotated
`@NotResolvedAsCdiBeanIntoJunitParameter`
That can be done without having such a qualifier defined in the extension
here. It can be defined and used in any project using it. I have the feeling
it's according to my current understanding not a general enough concern to have
it in the PR here. Does that match your point?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
