rmannibucau commented on code in PR #140:
URL: https://github.com/apache/openwebbeans/pull/140#discussion_r3546505201
##########
webbeans-impl/src/main/java/org/apache/webbeans/proxy/NormalScopeProxyFactory.java:
##########
@@ -395,7 +395,10 @@ protected void delegateNonInterceptedMethods(ClassLoader
classLoader, ClassWrite
exceptionTypeNames[i] =
Type.getType(exceptionTypes[i]).getInternalName();
Review Comment:
do we have the list of modifiers we want to drop? from the dozen of
modifiers I did review we already filter the ones we dont' want before so we
can almost passthrough or just force the ones we don't want if any no?
side note: we might extract the constant (`Modifier.PROTECTED |
Modifier.PUBLIC | MODIFIER_VARARGS | MODIFIER_BRIDGE | MODIFIER_SYNTHETIC` for
ex) instead of inlining it everytime.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
