rmannibucau commented on code in PR #140:
URL: https://github.com/apache/openwebbeans/pull/140#discussion_r3546673183
##########
webbeans-impl/src/main/java/org/apache/webbeans/proxy/NormalScopeProxyFactory.java:
##########
@@ -395,7 +395,10 @@ protected void delegateNonInterceptedMethods(ClassLoader
classLoader, ClassWrite
exceptionTypeNames[i] =
Type.getType(exceptionTypes[i]).getInternalName();
Review Comment:
but it can't be abstract, cant be native, can't be final, can't be static,
can't be private at that point in code. I'm not 100% sure about synchronized
(guess you're right but also that the impact is almost 0 in practise)
so from my window we just forward them
maybe final has a particular case but it should be explicitly handled if the
input method is final only IMHO
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
