rzo1 commented on code in PR #140:
URL: https://github.com/apache/openwebbeans/pull/140#discussion_r3546579635
##########
webbeans-impl/src/main/java/org/apache/webbeans/proxy/NormalScopeProxyFactory.java:
##########
@@ -395,7 +395,10 @@ protected void delegateNonInterceptedMethods(ClassLoader
classLoader, ClassWrite
exceptionTypeNames[i] =
Type.getType(exceptionTypes[i]).getInternalName();
Review Comment:
Concretely that would be something like `modifiers & ~(Modifier.ABSTRACT |
Modifier.SYNCHRONIZED | Modifier.NATIVE)`: ABSTRACT must go because the proxy
method gets a body (interface methods arrive abstract), SYNCHRONIZED shouldn't
be copied onto a delegating method (it would sync on the proxy instance, a
semantics change; the real method still synchronizes), NATIVE for safety even
though it's pre-filtered (didn't actually look that up). WDYT @struberg
@tandraschko ?
Meanwhile, I have extracted the modifiers set in a constant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
