dongjoon-hyun commented on a change in pull request #538:
URL: https://github.com/apache/orc/pull/538#discussion_r470280985
##########
File path: proto/orc_proto.proto
##########
@@ -343,7 +343,7 @@ message Encryption {
enum CalendarKind {
UNKNOWN_CALENDAR = 0;
// The Java default calendar changes from Julian to Gregorian
- // in 1583.
+ // in October 1582.
Review comment:
I'm wondering if the whole sentence makes sense. `The Java default
calendar changes from Julian to Gregorian in October 1582`? It sounds like
`Java` changes it in `October 1581`, doesn't it? Technically, 1582 is just a
year when Gregorian was introduced.
Shall we remove it (the whole sentence) simply?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
