dongjoon-hyun commented on a change in pull request #538:
URL: https://github.com/apache/orc/pull/538#discussion_r471672045
##########
File path: proto/orc_proto.proto
##########
@@ -343,7 +343,7 @@ message Encryption {
enum CalendarKind {
UNKNOWN_CALENDAR = 0;
// The Java default calendar changes from Julian to Gregorian
- // in 1583.
+ // in October 1582.
Review comment:
@findepi
We had better be specific to Java version because Apache Orc still supports
Java 7. I'm not aware of any change in Java 7. Do you have any reference saying
Java 7 changes it's default calendar or time-related stuff? IIRC, everything
started at Java 8.
- https://github.com/apache/orc/blame/master/README.md#L47
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
