findepi commented on a change in pull request #538:
URL: https://github.com/apache/orc/pull/538#discussion_r470427638
##########
File path: proto/orc_proto.proto
##########
@@ -343,7 +343,7 @@ message Encryption {
enum CalendarKind {
UNKNOWN_CALENDAR = 0;
// The Java default calendar changes from Julian to Gregorian
- // in 1583.
+ // in October 1582.
Review comment:
Quoting https://en.wikipedia.org/wiki/Gregorian_calendar:
_Thursday 4 October 1582 was followed by Friday 15 October 1582_
> It sounds like Java changes it in October 1581, doesn't it?
I think Java's java.util.Calendar and java.util.Date date calculations
follow the Oct 4 → Oct 15 shift, do they not?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
