dongjoon-hyun commented on a change in pull request #634:
URL: https://github.com/apache/orc/pull/634#discussion_r564172470
##########
File path:
java/mapreduce/src/test/org/apache/orc/mapred/TestOrcFileEvolution.java
##########
@@ -312,6 +314,26 @@ public void testPositional2() {
false, addSarg, true);
}
+ private void checkEvolutionPosn(String writerType, String readerType,
Review comment:
This function seems to be duplicated mostly with `checkEvolution`. Is
the only difference is the column name, `_col0` and `a`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
