dongjoon-hyun commented on a change in pull request #634:
URL: https://github.com/apache/orc/pull/634#discussion_r564175310
##########
File path:
java/mapreduce/src/test/org/apache/orc/mapred/TestOrcFileEvolution.java
##########
@@ -235,35 +235,37 @@ public void testListEvolution() {
@Test
public void testPreHive4243CheckEqual() {
// Expect success on equal schemas
- checkEvolution("struct<_col0:int,_col1:string>",
+ checkEvolutionPosn("struct<_col0:int,_col1:string>",
"struct<_col0:int,_col1:string>",
struct(1, "foo"),
- struct(1, "foo", null), false, addSarg, false);
+ struct(1, "foo", null),
+ false, addSarg, false);
Review comment:
Let's keep the original form to reduce the patch size.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
