autumnust opened a new pull request #637:
URL: https://github.com/apache/orc/pull/637
<!--
Thanks for sending a pull request! Here are some tips for you:
1. File a JIRA issue first and use it as a prefix of your PR title, e.g.,
`ORC-001: Fix ABC`.
2. Use your PR title to summarize what this PR proposes instead of
describing the problem.
3. Make PR title and description complete because these will be the
permanent commit log.
4. If possible, provide a concise and reproducible example to reproduce
the issue for a faster review.
5. If the PR is unfinished, use GitHub PR Draft feature.
-->
### What changes were proposed in this pull request?
This PR contains the very first part to make the implementation of
dictionary used for encoding pluggable, by introducing an interface
`Dictionary`. The subsequent PR will add HashTable-based Dictionary
implementation and compare with the existing RB-tree based dictionary.
For reviewers:
- Please comment if reflection-based initialization will be preferred or not
since I didn't found much of that within the code base.
- The `Dictionary` class isn't added with generic type declaration (e.g. we
could use a generic type `T` to replace `Text`). Please let me know if that's
necessary to add.
### Why are the changes needed?
### How was this patch tested?
Since this is mostly a refactoring, it is just passing all existing unit
tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
