autumnust commented on a change in pull request #637:
URL: https://github.com/apache/orc/pull/637#discussion_r578865688
##########
File path:
java/core/src/java/org/apache/orc/impl/writer/StringBaseTreeWriter.java
##########
@@ -55,15 +59,32 @@
// If the number of keys in a dictionary is greater than this fraction of
//the total number of non-null rows, turn off dictionary encoding
private final double dictionaryKeySizeThreshold;
+ protected Dictionary dictionary;
protected boolean useDictionaryEncoding = true;
private boolean isDirectV2 = true;
private boolean doneDictionaryCheck;
private final boolean strideDictionaryCheck;
+ static Dictionary createDict(Configuration conf) {
Review comment:
addressed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
