pgaref commented on a change in pull request #637:
URL: https://github.com/apache/orc/pull/637#discussion_r579090843
##########
File path: java/core/src/java/org/apache/orc/OrcConf.java
##########
@@ -105,6 +105,11 @@
"(default 10000 rows) else dictionary check will happen before\n" +
"writing first stripe. In both cases, the decision to use\n" +
"dictionary or not will be retained thereafter."),
+ DICTIONARY_IMPL("orc.dictionary.implementation", null,
Review comment:
I guess what I meant was that we should explicitly list the choices
(similar to BLOOM_FILTER_WRITE_VERSION):
* rbTree
* hash (not yet implemented
Moreover, I would set the hiveConfName same as the attribute -- I believe
null means that it does not apply to Hive
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
