pgaref commented on a change in pull request #736:
URL: https://github.com/apache/orc/pull/736#discussion_r665341392
##########
File path: java/core/src/java/org/apache/orc/impl/Dictionary.java
##########
@@ -47,6 +47,15 @@
*/
void getText(Text result, int position);
+ /**
+ * Given the position index, write the original string, before being encoded,
+ * to the OutputStream.
Review comment:
Can we please mention here that this is directly writing to out without
extra copies?
##########
File path: java/core/src/java/org/apache/orc/impl/Dictionary.java
##########
@@ -47,6 +47,15 @@
*/
void getText(Text result, int position);
+ /**
+ * Given the position index, write the original string, before being encoded,
+ * to the OutputStream.
Review comment:
Mention here that this is directly writing to out without extra copies?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
