pgaref commented on a change in pull request #736:
URL: https://github.com/apache/orc/pull/736#discussion_r665440165
##########
File path: java/core/src/java/org/apache/orc/impl/Dictionary.java
##########
@@ -47,6 +47,15 @@
*/
void getText(Text result, int position);
+ /**
+ * Given the position index, write the original string, before being encoded,
+ * to the OutputStream.
Review comment:
Thats true, but the way we pass the text argument here this seems to be
an one way option -- wound not mind adding the explanation on getText HT/Tree
implementations though
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
