dongjoon-hyun commented on a change in pull request #736:
URL: https://github.com/apache/orc/pull/736#discussion_r665720389
##########
File path: java/core/src/java/org/apache/orc/impl/DynamicByteArray.java
##########
@@ -222,10 +222,10 @@ public void setText(Text result, int offset, int length) {
* @param out the stream to write to
* @param offset the first offset to write
* @param length the number of bytes to write
- * @throws IOException
+ * @throws IOException if an I/O error occurs
Review comment:
@belugabehr . Could you revert this file change from this PR?
- First of all, for the line 227 and 228, this is irrelevant. They are only
style changes.
- Second, do we need to add this additional comment, `if an I/O error
occurs`? This is a Java default semantic. It doesn't add any new information
and ORC users don't think this function throws IOException always.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
