rizaon commented on a change in pull request #990:
URL: https://github.com/apache/orc/pull/990#discussion_r778437357
##########
File path: c++/include/orc/Vector.hh
##########
@@ -182,12 +182,20 @@ namespace orc {
uint64_t getMemoryUsage();
bool hasVariableLength();
+ bool hasElements = false;
+ bool hasPositions = false;
+
/**
* The offset of the first element of each list.
* The length of list i is offsets[i+1] - offsets[i].
*/
DataBuffer<int64_t> offsets;
+ /**
+ * Position of each element in their respective array.
+ */
+ DataBuffer<int64_t> pos;
Review comment:
Agree, ListColumnReader can just populate the offsets and leave the pos
calculation done by the client. Will remove this field.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@orc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
