rizaon commented on a change in pull request #990:
URL: https://github.com/apache/orc/pull/990#discussion_r778441116
##########
File path: c++/include/orc/Common.hh
##########
@@ -122,6 +122,11 @@ namespace orc {
StreamKind_BLOOM_FILTER_UTF8 = 8
};
+ enum ReadIntent {
Review comment:
Following the discussion in
[Vector.hh](https://github.com/apache/orc/pull/990/files/155cf1a171bcb498731bc95c4a939a445fa23114#r777800353),
I am thinking to rewrite this enum as follow
```
enum ArrayReadIntent {
ArrayReadIntent_ALL = 0,
ArrayReadIntent_OFFSETS = 1
};
```
So the choice is either to read all (data+offsets) or offsets only (we can
not read data without reading offsets).
Other than ListColumnReader, it looks like MapColumnReader and
UnionColumnReader can benefit from this selective read intent, such as when
dealing with "select count(*)" kind of query where no materialization is
required. This is out of the scope of ORC-450 though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
