dongjoon-hyun commented on a change in pull request #990:
URL: https://github.com/apache/orc/pull/990#discussion_r778567307



##########
File path: c++/include/orc/Reader.hh
##########
@@ -149,6 +149,26 @@ namespace orc {
      */
     RowReaderOptions& includeTypes(const std::list<uint64_t>& types);
 
+    /**
+     * A map of <typeId, ArrayReadIntent> used as a parameter in
+     * RowReaderOptions::includeTypesWithIntents.

Review comment:
       Actually, this PR also uses it at `getReadIntents` too. We had better 
describe the definition a little more instead of listing the references because 
the references could be changed.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@orc.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to