dongjoon-hyun commented on a change in pull request #990:
URL: https://github.com/apache/orc/pull/990#discussion_r778570774
##########
File path: c++/src/Reader.cc
##########
@@ -290,6 +291,15 @@ namespace orc {
return selectedColumns;
}
+ ArrayReadIntent RowReaderImpl::getReadIntent(uint64_t typeId) const {
+ auto elem = readIntents.find(typeId);
+ if (elem == readIntents.end()) {
+ return ArrayReadIntent_ALL;
+ } else {
+ return elem->second;
Review comment:
Do we have a test coverage for this code path? I expected two test cases.
- typeId is mapped to `ArrayReadIntent_ALL` (although this is unlikely but
for completeness of test coverage).
- typeId is mapped to `ArrayReadIntent_OFFSETS`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@orc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
