rizaon commented on a change in pull request #990:
URL: https://github.com/apache/orc/pull/990#discussion_r779226390
##########
File path: c++/include/orc/Reader.hh
##########
@@ -565,6 +591,15 @@ namespace orc {
*/
virtual void seekToRow(uint64_t rowNumber) = 0;
+ /**
+ * Get an ArrayReadIntent for a given typeId.
+ * @param typeId the type id to look up.
+ * @return an ArrayReadIntent that was specified for given typeId through
+ * RowReaderOptions::includeTypesWithIntents. If no ArrayReadIntent was
+ * specified for typeId, return ArrayReadIntent_ALL.
+ */
+ virtual ArrayReadIntent getReadIntent(uint64_t typeId) const = 0;
Review comment:
My plan is to return `ArrayReadIntent_ALL` if typeId is not selected or
selected without any specific read intent (in case
`RowReaderOptions::includeTypes()` is being used). I understand the naming is a
bit confusing. Will think more about this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@orc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
