rizaon commented on a change in pull request #990: URL: https://github.com/apache/orc/pull/990#discussion_r780619777
########## File path: c++/include/orc/Reader.hh ########## @@ -565,6 +591,15 @@ namespace orc { */ virtual void seekToRow(uint64_t rowNumber) = 0; + /** + * Get an ArrayReadIntent for a given typeId. + * @param typeId the type id to look up. + * @return an ArrayReadIntent that was specified for given typeId through + * RowReaderOptions::includeTypesWithIntents. If no ArrayReadIntent was + * specified for typeId, return ArrayReadIntent_ALL. + */ + virtual ArrayReadIntent getReadIntent(uint64_t typeId) const = 0; Review comment: Deleted in latest commit. ########## File path: c++/src/ColumnReader.cc ########## @@ -993,6 +993,9 @@ namespace orc { void nextInternal(ColumnVectorBatch& rowBatch, uint64_t numValues, char *notNull); + + void readArrayIndices(const int64_t *arrayOffsets, uint64_t arrayCount, Review comment: Deleted in latest commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@orc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org