Great, thanks for the pointer! Not necessary for this release, but would it make sense to consider releasing simply a git-archive of the release tag? I suppose the use of submodules would make this non-trivial.
On Tue, Sep 17, 2019 at 11:13 AM Otto van der Schaaf <osch...@we-amp.com> wrote: > Thanks for having a look! > > The process for getting to a source tarball is described here: > > https://github.com/apache/incubator-pagespeed-mod/wiki/Release-Process#building-the-source-tarball > > I'll take a look at the things you pointed out, and create another one to > address those. > > Otto > > On Tue, Sep 17, 2019 at 5:03 PM Jukka Zitting <jukka.zitt...@gmail.com> > wrote: > > > Hi, > > > > Awesome, thanks for putting up the release candidate and sorry for the > late > > response! > > > > I'm looking at it now, and will post more detailed notes later today. > That > > said, a few immediate observations/questions: > > > > - It would be good for files like README, LICENSE, etc. to be at the > top > > level of the source tarball. Do we need the src/ directory, or could > > everything just be one level higher in the tarball? > > > > - The README doesn't tell me how to build or install the package. > > > > - Are all the third_party licenses reflected or referenced in the > > top-level LICENSE? A quick spot check showed that at least the RE2 > > license > > is missing. > > > > - Is there a corresponding tag in the Git repository? How was the > > tarball generated from the version controlled sources? I notice that > at > > least the devel and html subdirectories are excluded. > > > > PS. I branched the topic to [DISCUSS] to avoid polluting the vote thread. > > > > Best, > > > > Jukka > > > > On Wed, Sep 11, 2019 at 5:26 PM Otto van der Schaaf <osch...@we-amp.com> > > wrote: > > > > > +1 from me obviously :-) > > > > > > On Wed, Sep 11, 2019 at 11:25 PM Joshua Marantz > > > <jmara...@google.com.invalid> > > > wrote: > > > > > > > +1 > > > > > > > > > > > > On Wed, Sep 11, 2019 at 5:22 PM Otto van der Schaaf < > > osch...@we-amp.com> > > > > wrote: > > > > > > > > > Hi all, > > > > > > > > > > Raising a vote for accepting the > > > mod-pagespeed-beta-1.14.36.1-r0.tar.bz2 > > > > > for release, staged at: > > > > > http://people.apache.org/~oschaaf/mod_pagespeed/1.14.36.1-rc2/ > > > > > > > > > > We need three +1 votes to move forward and post it for review on > the > > > > > incubator general list for approval. > > > > > > > > > > For those who want context on the release procedure: > > > > > https://incubator.apache.org/policy/incubation.html > > > > > > > > > > Otto > > > > > > > > > > > > > > >
