So I had another look, and I think we are still good with respect to licenses.
On Wed, Sep 18, 2019 at 10:57 PM Jukka Zitting <jukka.zitt...@gmail.com> wrote: > Sounds good, thanks! I'll go through the list of licenses also myself > before +1'ing on the VOTE thread. > > On Wed, Sep 18, 2019 at 4:40 PM Otto van der Schaaf <osch...@we-amp.com> > wrote: > >> I created a PR addressing the license/notice issues: >> https://github.com/apache/incubator-pagespeed-mod/pull/1955 >> Notice did become a little elaborate, I bubbled up everything I could >> find in the dependencies. >> >> I'll now look into moving the sources in the tarball up one level. >> >> On Wed, Sep 18, 2019 at 5:23 PM Jukka Zitting <jukka.zitt...@gmail.com> >> wrote: >> >>> Looks good, thanks! The only addition I'd make is an explanatory header >>> between the ASL and the other licenses. Something like this: >>> >>> MOD_PAGESPEED SUBCOMPONENTS >>> >>> >> Done >> >> >>> mod_pagespeed includes components with separate copyright notices and >>> license terms. Your use of these components is subject to the terms and >>> conditions of the following licenses: >>> >>> >>> Have we checked that all the 3rd party licenses fall within the policy >>> in http://www.apache.org/legal/resolved.html? >>> >> >> I think I checked that in the past, yes, I couldn't find any violations >> back then. I don't think anything relevant has >> changed meantime, but let me double check. >> >> >>> Excluding the Apache-licensed deps is fine, though we should >>> double-check whether any of them have NOTICE files that should be merged >>> into the top-level mod_pagespeed NOTICE. >>> >>> In general it looks like our NOTICE file includes too much detail. As a >>> general rule anything that's already included in LICENSE probably shouldn't >>> be covered in NOTICE. And something that's not explicitly required to be in >>> the NOTICE should generally be left out. See >>> http://www.apache.org/dev/licensing-howto.html#mod-notice for details. >>> Based on a quick reading (to be verified in more detail), it looks like the >>> following might be sufficient for us: >>> >>> Apache PageSpeed >>> Copyright 2018-2019 The Apache Software Foundation >>> >>> This product includes software developed at >>> The Apache Software Foundation (http://www.apache.org/). >>> >>> Codebase originally donated by Google Inc: >>> Copyright (C) 2010-2017 Google Inc. >>> >>> >>> On Wed, Sep 18, 2019 at 10:08 AM Otto van der Schaaf <osch...@we-amp.com> >>> wrote: >>> >>>> @Jukka Zitting <jukka.zitt...@gmail.com> >>>> >>>> As a first step, I'm proposing up update LICENSE so it would look like: >>>> https://gist.github.com/oschaaf/09458d082cf767fb24353a82cb3b4ae9 >>>> Indeed, dependencies where missing in there, nice catch. Note: I left >>>> out Apache licensenced deps >>>> like apr and serf, is that OK? I tried to list every other dependency >>>> which was >>>> licensed otherwise. >>>> >>>> There's also our NOTICE which would be good to double check: >>>> https://github.com/apache/incubator-pagespeed-mod/blob/master/NOTICE >>>> >>>> It would be really grateful if someone could verify I did the right >>>> thing here. >>>> >>>> >>>> On Tue, Sep 17, 2019 at 10:10 PM Longinos Ferrando <lof...@gmail.com> >>>> wrote: >>>> >>>>> +1 >>>>> >>>>> On 2019/09/11 21:22:19, Otto van der Schaaf <osch...@we-amp.com> >>>>> wrote: >>>>> > Hi all, >>>>> > >>>>> > Raising a vote for accepting the >>>>> mod-pagespeed-beta-1.14.36.1-r0.tar.bz2 >>>>> > for release, staged at: >>>>> > http://people.apache.org/~oschaaf/mod_pagespeed/1.14.36.1-rc2/ >>>>> > >>>>> > We need three +1 votes to move forward and post it for review on the >>>>> > incubator general list for approval. >>>>> > >>>>> > For those who want context on the release procedure: >>>>> > https://incubator.apache.org/policy/incubation.html >>>>> > >>>>> > Otto >>>>> > >>>>> >>>>
