Sergio, please do!
Also, I've added you guys to the committers list in JIRA and to the
PARQUET project's admin list so that you can add contributors. When you
merge a PR, please add the contributor to the contributors list (if they
aren't already there) and assign the JIRA to them to reflect the
contribution.
Thanks!
rb
On 12/03/2015 08:18 AM, Sergio Pena wrote:
Thanks Julien.
I just tested merging a PR and it works. Btw, the following line in the
README did not work for me:
|git remote add apache-github [email protected]:apache/parquet-mr.git|
I had permission issues when running the script. I had to use this one:
|git remote add apache-github https://github.com/apache/parquet-mr|
Should I edit the README.md file or there is something wrong I was doing?
- Sergio
On Thu, Dec 3, 2015 at 2:21 AM, Cheng Lian <[email protected]
<mailto:[email protected]>> wrote:
Thanks Julien for setting this up!
Just created a placeholder JIRA ticket for new committers to test
their committership in the future:
https://issues.apache.org/jira/browse/PARQUET-398
They can create PR to update dev/COMMITTERS.md and have the JIRA ID
of this ticket in the PR title. Similar to the one I just opened:
https://github.com/apache/parquet-mr/pull/298
Cheng
On 12/3/15 3:24 AM, Julien Le Dem wrote:
Hi Sergio and Cheng,
(cc'ing the dev list since this is useful information in general)
I have added both of you to the parquet ldap group.
That gives you write access to the repo.
Please open a pull request to add yourselves to this list:
https://github.com/apache/parquet-mr/blob/master/dev/COMMITTERS.md
Some details on how to merge a PR here:
https://github.com/apache/parquet-mr/blob/master/dev/README.md
Feel free to send feedback or improve those tools.
The process to merge a Pull Request is to have a committer (that
includes yourselves now!) review and give it a +1 and then merge
it using dev/merge_parquet_pr.py.
Please note that the tool will require the PR description to be
prefixed by the JIRA id. ex: "PARQUET-1234567: my awesome
contribution"
If the contribution is coming from a committer, a +1 is expected
from another committer (feel free to nag people).
One does not need to be a committer to give a review, please
encourage others to give reviews too.
However a committer is required to commit! It is our
responsibility as committers to make sure contributions get
committed or receive the appropriate feedback so that they can
be committed.
Typically things that change public APIs need a little more
consensus than things that don't. Use your best judgement!
Welcome again.
--
Julien
--
Ryan Blue
Software Engineer
Cloudera, Inc.
