[
https://issues.apache.org/jira/browse/PARQUET-611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15280378#comment-15280378
]
Deepak Majeti commented on PARQUET-611:
---------------------------------------
[~wesmckinn] [~xhochy] do you have any thoughts on this ?
> Use google logging library (glog)
> ---------------------------------
>
> Key: PARQUET-611
> URL: https://issues.apache.org/jira/browse/PARQUET-611
> Project: Parquet
> Issue Type: Improvement
> Components: parquet-cpp
> Reporter: Deepak Majeti
>
> The current logging pragmas have some drawbacks.
> Mainly, the statements in the logs ({{eg. DCHECK(condition)}}) are not used
> in a release mode build. This causes plenty of warnings.
> Secondly, we cannot use the logging pragmas directly on code.
> eg. {{DCHECK(foo())}} will not call {{foo()}} in a release mode build.
> Glog handles all these cases.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
