[
https://issues.apache.org/jira/browse/PARQUET-611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15280759#comment-15280759
]
Wes McKinney commented on PARQUET-611:
--------------------------------------
I'd prefer not to leak the glog headers into the public API (which would
require any user of libparquet to also install glog). Is there some other
solution that does not cause this to happen?
> Use google logging library (glog)
> ---------------------------------
>
> Key: PARQUET-611
> URL: https://issues.apache.org/jira/browse/PARQUET-611
> Project: Parquet
> Issue Type: Improvement
> Components: parquet-cpp
> Reporter: Deepak Majeti
>
> The current logging pragmas have some drawbacks.
> Mainly, the statements in the logs ({{eg. DCHECK(condition)}}) are not used
> in a release mode build. This causes plenty of warnings.
> Secondly, we cannot use the logging pragmas directly on code.
> eg. {{DCHECK(foo())}} will not call {{foo()}} in a release mode build.
> Glog handles all these cases.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
