[
https://issues.apache.org/jira/browse/PARQUET-710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15466064#comment-15466064
]
Wes McKinney commented on PARQUET-710:
--------------------------------------
For what it's worth, the intent of the current structure was to permit test
fixtures to be created (for testing edge cases in these classes). PIMPL was the
wrong name for this, more of a dependency injection
> Modify ParquetFileReader/RowGroupReader design with pure PIMPL pattern
> ----------------------------------------------------------------------
>
> Key: PARQUET-710
> URL: https://issues.apache.org/jira/browse/PARQUET-710
> Project: Parquet
> Issue Type: Bug
> Components: parquet-cpp
> Reporter: Deepak Majeti
> Assignee: Deepak Majeti
>
> The current PIMPL idiom exposes private metadata members in its header. With
> the metadata implementation, this can be removed.
> This also helps simplify the design and remove virtual functions.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
