[
https://issues.apache.org/jira/browse/PARQUET-710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15466254#comment-15466254
]
Deepak Majeti commented on PARQUET-710:
---------------------------------------
The injection capability is retained.
The private members are removed in line with PIMPL.
Patch available: https://github.com/apache/parquet-cpp/pull/154
> Modify ParquetFileReader/RowGroupReader design with pure PIMPL pattern
> ----------------------------------------------------------------------
>
> Key: PARQUET-710
> URL: https://issues.apache.org/jira/browse/PARQUET-710
> Project: Parquet
> Issue Type: Bug
> Components: parquet-cpp
> Reporter: Deepak Majeti
> Assignee: Deepak Majeti
>
> The current PIMPL idiom exposes private metadata members in its header. With
> the metadata implementation, this can be removed.
> This also helps simplify the design and remove virtual functions.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
