As there have been no positive, binding votes this RC hasn't passed. I'll post a new one in a couple of hours with the latest fixes merged on master.
-- Uwe L. Korn On Mon, Feb 20, 2017, at 10:49 PM, Wes McKinney wrote: > See PARQUET-885, PARQUET-886 > > On Mon, Feb 20, 2017 at 4:45 PM, Wes McKinney <[email protected]> > wrote: > > @Uwe -- we might want to exclude system paths from > > https://github.com/apache/parquet-cpp/blob/master/cmake_modules/FindThrift.cmake > > since the system Thrift likely hasn't been build with -fPIC. > > > > We also need to note the Boost dependency in README.md. The rest > > should build out-of-the-box via ExternalProjects, and there are no > > runtime dependencies on Thrift, snappy, gzip, or Boost because we are > > statically linking. > > > > In light of the Thrift issue I revise my vote to -0 and recommend we > > do another RC after fixing the Thrift issue. > > > > On Mon, Feb 20, 2017 at 4:36 PM, Ryan Blue <[email protected]> > > wrote: > >> Tarball: the tarball should unpack to the final location > >> (apache-parquet-cpp-1.0.0) without the RC. That way, we can just copy the > >> tarball from the candidate directory to the release directory and all the > >> signatures and everything are still valid. You might want to look at the > >> scripts that parquet-mr uses. Those are also based on Aurora, but I updated > >> them when we solved release problems the incubator caught. > >> > >> Build: initially, I didn’t set THRIFT_HOME to allow it to build the > >> third-party lib along with everything else, but that fails when it can’t > >> find thrift: > >> > >> Scanning dependencies of target thrift-deps > >> make[2]: *** No rule to make target > >> 'THRIFT_STATIC_LIB_PATH-NOTFOUND/libthrift.a', needed by > >> 'src/parquet/parquet_types.cpp'. Stop. > >> CMakeFiles/Makefile2:489: recipe for target > >> 'CMakeFiles/thrift-deps.dir/all' failed > >> make[1]: *** [CMakeFiles/thrift-deps.dir/all] Error 2 > >> Makefile:138: recipe for target 'all' failed > >> make: *** [all] Error 2 > >> > >> Maybe there’s something wrong with how it detects that it should build > >> thrift instead of using the supplied thrift? > >> > >> rb > >> > >> On Mon, Feb 20, 2017 at 1:26 PM, Uwe L. Korn <[email protected]> wrote: > >> > >> The RC is based on the commit with hash > >>> bdd1fa53d6c8a76777d3fade3f7f80c3cbbd2d89 > >>> > >>> For thrift version: yes, you need to rebuild it with -fPIC. Also > >>> parquet-cpp should automatically build Thrift by itself in its CMake > >>> setup if you don't have it installed. > >>> > >>> As the scripts are taken from Apache Aurora, I assumed that they follow > >>> the Apache guidelines. But since I made the Arrow release week (and > >>> seeing the differences between them), I'm a bit concerned that in the > >>> Arrow case we voted on the tarball that was finally released (via a copy > >>> in SVN) and here we have an RC-specific tarball that needs to be > >>> regenerated on release as the top folder in the tarball contains the > >>> RC-number in the version string. Is this a problem? > >>> > >>> -- > >>> Uwe L. Korn > >>> [email protected] > >>> > >>> On Mon, Feb 20, 2017, at 09:50 PM, Ryan Blue wrote: > >>> > What commit hash is this release vote for? We are technically voting on > >>> > a > >>> > hash because tags can be rewritten in git. > >>> > > >>> > For the tarball, I checked the signature and checksums and they look > >>> > fine, > >>> > but I couldn’t get it to build. I hit an error when linking against my > >>> > thrift 0.7.0 install: > >>> > > >>> > /usr/bin/ld: /home/blue/.local/lib/libthrift.a(TBufferTransports.o): > >>> > relocation R_X86_64_32 against `.rodata' can not be used when making a > >>> > shared object; recompile with -fPIC > >>> > /home/blue/.local/lib/libthrift.a: error adding symbols: Bad value > >>> > collect2: error: ld returned 1 exit status > >>> > CMakeFiles/parquet_shared.dir/build.make:114: recipe for target > >>> > 'build/debug/libparquet.so' failed > >>> > make[2]: *** [build/debug/libparquet.so] Error 1 > >>> > CMakeFiles/Makefile2:181: recipe for target > >>> > 'CMakeFiles/parquet_shared.dir/all' failed > >>> > make[1]: *** [CMakeFiles/parquet_shared.dir/all] Error 2 > >>> > Makefile:138: recipe for target 'all' failed > >>> > make: *** [all] Error 2 > >>> > > >>> > I’m on Ubuntu and didn’t use brew install, so maybe I need to compile > >>> > thrift with -fPIC? Does anyone know how to get it building on Ubuntu? > >>> > > >>> > Also, I needed to install libboost-dev, libboost-system-dev, and > >>> > libboost-filesystem-dev and set THRIFT_HOME for CMake. Maybe we should > >>> > document how to get up and running on a linux build machine. > >>> > > >>> > rb > >>> > > >>> > On Sun, Feb 19, 2017 at 3:44 PM, Wes McKinney <[email protected]> > >>> > wrote: > >>> > > >>> > +1 (binding) > >>> > > > >>> > > - Verified signature > >>> > > - Built with -DPARQUET_ARROW=on and ran unit tests > >>> > > > >>> > > - Wes > >>> > > > >>> > > On Sun, Feb 19, 2017 at 1:01 PM, Uwe L. Korn <[email protected]> wrote: > >>> > > > Small amendment to the previous mail: > >>> > > > > >>> > > > The vote will be open for the next ~72 hours ending at 18:45 CET, > >>> > > > February 22, 2017. > >>> > > > > >>> > > > > >>> > > > On Sun, Feb 19, 2017, at 06:39 PM, Uwe L. Korn wrote: > >>> > > >> All, > >>> > > >> > >>> > > >> I propose that we accept the following release candidate as the > >>> official > >>> > > >> Apache Parquet C++ 1.0.0 release. > >>> > > >> > >>> > > >> Parquet C++ 1.0.0-rc1 includes the following: > >>> > > >> --- > >>> > > >> The RELEASE NOTES for the release are available at: > >>> > > >> https://git-wip-us.apache.org/repos/asf?p=parquet-cpp.git&f= > >>> > > RELEASE-NOTES.md&hb=rel/1.0.0-rc1 > >>> > > >> > >>> > > >> The CHANGELOG for the release is available at: > >>> > > >> https://git-wip-us.apache.org/repos/asf?p=parquet-cpp.git&f= > >>> > > CHANGELOG&hb=rel/1.0.0-rc1 > >>> > > >> > >>> > > >> The tag used to create the release candidate is: > >>> > > >> https://git-wip-us.apache.org/repos/asf?p=parquet-cpp.git;a= > >>> > > shortlog;h=refs/tags/rel/1.0.0-rc1 > >>> > > >> > >>> > > >> The release candidate is available at: > >>> > > >> https://dist.apache.org/repos/dist/dev/parquet/1.0.0-rc1/apa > >>> > > che-parquet-cpp-1.0.0-rc1.tar.gz > >>> > > >> > >>> > > >> The MD5 checksum of the release candidate can be found at: > >>> > > >> https://dist.apache.org/repos/dist/dev/parquet/1.0.0-rc1/apa > >>> > > che-parquet-cpp-1.0.0-rc1.tar.gz.md5 > >>> > > >> > >>> > > >> The signature of the release candidate can be found at: > >>> > > >> https://dist.apache.org/repos/dist/dev/parquet/1.0.0-rc1/apa > >>> > > che-parquet-cpp-1.0.0-rc1.tar.gz.asc > >>> > > >> > >>> > > >> The GPG key used to sign the release are available at: > >>> > > >> https://dist.apache.org/repos/dist/dev/parquet/KEYS > >>> > > >> > >>> > > >> Please download, verify, and test. > >>> > > >> > >>> > > >> The vote will close on > >>> > > >> > >>> > > >> [ ] +1 Release this as Apache Parquet C++ 1.0.0 > >>> > > >> [ ] +0 > >>> > > >> [ ] -1 Do not release this as Apache Parquet C++ 1.0.0 because... > >>> > > >> > >>> > > >> --- > >>> > > >> > >>> > > >> Build and run tests, thus I vote > >>> > > >> > >>> > > >> +1 (non-binding) > >>> > > >> > >>> > > >> Uwe > >>> > > >> > >>> > > > >>> > > >>> > -- > >>> > Ryan Blue > >>> > Software Engineer > >>> > Netflix > >>> > >> > >> -- > >> Ryan Blue > >> Software Engineer > >> Netflix
