[
https://issues.apache.org/jira/browse/PARQUET-1226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16369573#comment-16369573
]
ASF GitHub Bot commented on PARQUET-1226:
-----------------------------------------
wesm commented on a change in pull request #442: PARQUET-1226: Fixes for
CHECKIN compiler warning level with clang 5.0
URL: https://github.com/apache/parquet-cpp/pull/442#discussion_r169181576
##########
File path: src/parquet/util/comparison.h
##########
@@ -38,15 +38,13 @@ class PARQUET_EXPORT CompareDefault : public Comparator {
public:
typedef typename DType::c_type T;
CompareDefault() {}
- virtual ~CompareDefault() {}
Review comment:
@cpcloud I wanted to confirm the the C++ standard says that declaring empty
virtual dtors in subclasses is unnecessary (per associated comments on this
recently in Arrow)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [C++] Fix new build warnings with clang 5.0
> -------------------------------------------
>
> Key: PARQUET-1226
> URL: https://issues.apache.org/jira/browse/PARQUET-1226
> Project: Parquet
> Issue Type: Bug
> Components: parquet-cpp
> Reporter: Wes McKinney
> Assignee: Wes McKinney
> Priority: Major
> Fix For: cpp-1.5.0
>
>
> Follow-on work since Apache Arrow has migrated to clang 5.0 in ARROW-2117
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
