[ 
https://issues.apache.org/jira/browse/PARQUET-1226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16369587#comment-16369587
 ] 

ASF GitHub Bot commented on PARQUET-1226:
-----------------------------------------

cpcloud commented on a change in pull request #442: PARQUET-1226: Fixes for 
CHECKIN compiler warning level with clang 5.0
URL: https://github.com/apache/parquet-cpp/pull/442#discussion_r169184645
 
 

 ##########
 File path: src/parquet/util/comparison.h
 ##########
 @@ -38,15 +38,13 @@ class PARQUET_EXPORT CompareDefault : public Comparator {
  public:
   typedef typename DType::c_type T;
   CompareDefault() {}
-  virtual ~CompareDefault() {}
 
 Review comment:
   Yep.
   
   Found [this SO answer](https://stackoverflow.com/a/27220184/564538), then I 
downloaded the standard and confirmed (the answer says subsection 9, but I 
found it in subsection 8) 
   
   Section 12.4/8 says:
   
   ```
   If a class has a base class with a
   virtual destructor, its destructor (whether user- or implicitly-declared) is 
virtual.
   ```
   
   Coupled with the implicit definitions of a destructor if they are used (and 
not already defined) this means defining an empty virtual destructor is 
unnecessary.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [C++] Fix new build warnings with clang 5.0
> -------------------------------------------
>
>                 Key: PARQUET-1226
>                 URL: https://issues.apache.org/jira/browse/PARQUET-1226
>             Project: Parquet
>          Issue Type: Bug
>          Components: parquet-cpp
>            Reporter: Wes McKinney
>            Assignee: Wes McKinney
>            Priority: Major
>             Fix For: cpp-1.5.0
>
>
> Follow-on work since Apache Arrow has migrated to clang 5.0 in ARROW-2117



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to