-1 Junjie, I think we need to vote to adopt the proposed spec before committing code that implements it.
On Fri, May 31, 2019 at 7:40 AM Wes McKinney <[email protected]> wrote: > Are there any tools or scripts to assist with integration testing the > Bloom filter across Java and C++ (or is it a manual process)? I think > we are relying on a binary file in the C++ library to test > deserialization. > > On Thu, May 30, 2019 at 9:11 PM 俊杰陈 <[email protected]> wrote: > > > > Hi developers > > > > I 'd like to propose a vote for merging the Bloom filter branch to > master. > > Currently the feature on branch is functional well and can be use > directly, > > it is also a independent feature that won't break existing feature or > > ongoing feature development such as dictionary filter and page index, > when > > the switch is off. Though there are optimizations we should do, such as > > xxhash, folding bloom filters and etc., I think we can handle > optimization > > further on the master. > > > > Please help to vote on this. > > > > > > > > Thanks & Best Regards > -- Ryan Blue Software Engineer Netflix
