Thanks Zoltan I planed to update naming issue when we have another update. Let me open a jira to do this.
For the hash choice from Todd, both of xxh3 and murmur3 can be coexist at same time, so I planed to add xxh3 later since it needs some effort to implement and benchmark. On Tue, Jun 11, 2019 at 7:27 PM Zoltan Ivanfi <[email protected]> wrote: > Hi, > > It has been merged into master but has not been released yet. In fact, > I asked for a minor change before releasing it: > > https://github.com/apache/parquet-format/commit/54839ad5e04314c944fed8aa4bc6cf15e4a58698#r31084264 > It may seem like a nit, but I think the naming of the parquet > structures is important. I also see that Todd raised some concerns > about the choice of the hash function. > > Br, > > Zoltan > > > On Fri, Jun 7, 2019 at 9:30 PM Jim Apple <[email protected]> wrote: > > > > On 2019/05/31 16:01:54, Ryan Blue <[email protected]> wrote: > > > -1 > > > > > > Junjie, I think we need to vote to adopt the proposed spec before > > > committing code that implements it. > > > > Ryan, it seems like Junjie and I think that the spec has already been > adopted and is in the repo: > > > > > https://github.com/apache/parquet-format/commit/54839ad5e04314c944fed8aa4bc6cf15e4a58698 > > > > Is your view that this is in the repo but has not been adopted? > > > > If it has, do you see other blockers to a vote on the implementations? > -- Thanks & Best Regards
