gszadovszky commented on a change in pull request #164:
URL: https://github.com/apache/parquet-format/pull/164#discussion_r569240337
##########
File path: src/main/thrift/parquet.thrift
##########
@@ -1041,6 +1041,13 @@ struct FileMetaData {
* Used only in encrypted files with plaintext footer.
*/
9: optional binary footer_signing_key_metadata
+
+ /**
+ * This field might be set with the version number of a parquet-format
release
+ * if this file is created by using only the features listed in the related
+ * list of core features. See CoreFeatures.md for details.
Review comment:
It's a good point, @jorisvandenbossche. However, I am not sure what the
other version is for. Maybe, it would be better to specify that one correctly
and it would be clear that this one is different thing.
Currently parquet-mr always writes `1` to that version field. I guess this
is a file format version that we never incremented as it is backward compatible
to the first ones we wrote. If it is the case then I think we will never
increment it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
