gszadovszky commented on a change in pull request #164:
URL: https://github.com/apache/parquet-format/pull/164#discussion_r569260891
##########
File path: src/main/thrift/parquet.thrift
##########
@@ -1041,6 +1041,13 @@ struct FileMetaData {
* Used only in encrypted files with plaintext footer.
*/
9: optional binary footer_signing_key_metadata
+
+ /**
+ * This field might be set with the version number of a parquet-format
release
+ * if this file is created by using only the features listed in the related
+ * list of core features. See CoreFeatures.md for details.
Review comment:
It doesn't sound good. It means that we are using a required field for
different purposes. Because it is required we cannot deprecate it easily.
parquet-mr does not read this field only writes `1` all the time. What does
parquet-cpp does with this value at the read path?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
