jorisvandenbossche commented on a change in pull request #164:
URL: https://github.com/apache/parquet-format/pull/164#discussion_r569249894



##########
File path: src/main/thrift/parquet.thrift
##########
@@ -1041,6 +1041,13 @@ struct FileMetaData {
    * Used only in encrypted files with plaintext footer. 
    */ 
   9: optional binary footer_signing_key_metadata
+
+  /**
+   * This field might be set with the version number of a parquet-format 
release
+   * if this file is created by using only the features listed in the related
+   * list of core features. See CoreFeatures.md for details.

Review comment:
       In Arrow (parquet-cpp) this `version` field actually gets populated with 
`1` or `2`, and depending on that different features are used to write the file 
(version 2 enabled some additional features, like writing nanosecond 
timestamps, or using RLE_DICTIONARY instead of PLAIN_DICTIONARY)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to