[
https://issues.apache.org/jira/browse/PARQUET-1979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17284920#comment-17284920
]
ASF GitHub Bot commented on PARQUET-1979:
-----------------------------------------
shangxinli commented on a change in pull request #869:
URL: https://github.com/apache/parquet-mr/pull/869#discussion_r576383236
##########
File path:
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/metadata/ColumnChunkMetaData.java
##########
@@ -157,14 +157,14 @@ public static ColumnChunkMetaData get(
totalUncompressedSize);
}
}
-
+
// In sensitive columns, the ColumnMetaData structure is encrypted (with
column-specific keys), making the fields like Statistics invisible.
// Decryption is not performed pro-actively, due to performance and
authorization reasons.
// This method creates an a shell ColumnChunkMetaData object that keeps the
encrypted metadata and the decryption tools.
// These tools will activated later - when/if the column is projected.
- public static ColumnChunkMetaData
getWithEncryptedMetadata(ParquetMetadataConverter parquetMetadataConverter,
ColumnPath path,
+ public static ColumnChunkMetaData
getWithEncryptedMetadata(ParquetMetadataConverter parquetMetadataConverter,
ColumnPath path,
Review comment:
Is this intentionally changed? I see multiple places have changed like
this. These kinds of changes could cause other pending PRs conflict.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Optional bloom_filter_offset is filled if no bloom filter is present
> --------------------------------------------------------------------
>
> Key: PARQUET-1979
> URL: https://issues.apache.org/jira/browse/PARQUET-1979
> Project: Parquet
> Issue Type: Bug
> Affects Versions: 1.12.0
> Reporter: Gabor Szadovszky
> Assignee: Gabor Szadovszky
> Priority: Major
>
> Currently the field
> [bloom_filter_offset|https://github.com/apache/parquet-format/blob/master/src/main/thrift/parquet.thrift#L750]
> is filled (with the value {{0}}) even if no bloom filter is saved for the
> related column chunk. This is not correct as this field is optional so we
> should not fill it in this case.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
