[
https://issues.apache.org/jira/browse/PARQUET-1979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17285148#comment-17285148
]
ASF GitHub Bot commented on PARQUET-1979:
-----------------------------------------
chenjunjiedada commented on pull request #869:
URL: https://github.com/apache/parquet-mr/pull/869#issuecomment-779779278
@gszadovszky, Thanks for fixing this!
It looks correct to me. Just one minor thing, could you help to add a unit
test to check null bloom filter offset when there is no bloom filter?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Optional bloom_filter_offset is filled if no bloom filter is present
> --------------------------------------------------------------------
>
> Key: PARQUET-1979
> URL: https://issues.apache.org/jira/browse/PARQUET-1979
> Project: Parquet
> Issue Type: Bug
> Affects Versions: 1.12.0
> Reporter: Gabor Szadovszky
> Assignee: Gabor Szadovszky
> Priority: Major
>
> Currently the field
> [bloom_filter_offset|https://github.com/apache/parquet-format/blob/master/src/main/thrift/parquet.thrift#L750]
> is filled (with the value {{0}}) even if no bloom filter is saved for the
> related column chunk. This is not correct as this field is optional so we
> should not fill it in this case.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
