[
https://issues.apache.org/jira/browse/PARQUET-2070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17390805#comment-17390805
]
ASF GitHub Bot commented on PARQUET-2070:
-----------------------------------------
sv3ndk opened a new pull request #919:
URL: https://github.com/apache/parquet-mr/pull/919
### Jira
- [ ] My PR addresses the following [Parquet
Jira](https://issues.apache.org/jira/browse/PARQUET-2070)
### Tests
- [ ] My PR does not need testing for this extremely good reason: I'm simply
removing a private method, no feature has changes, existing unit are sufficient
to validate the change.
### Commits
This minor PR:
* removes usage of the deprecated syntax `TextFormat.printToString(asProto)`
the now recommended simple `.toString()`
* the private method where this code was present was only invoked from one
place, where the protobuf Descriptor was already available => I moved the logic
there, which removes one reflection invocation and makes the code slightly more
concise (and probably trivially faster as well)
* I also added a mention of protobuf in the readme, since Thrif and Avro
were mentioned already
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> Replace deprecated syntax in protobuf support
> ---------------------------------------------
>
> Key: PARQUET-2070
> URL: https://issues.apache.org/jira/browse/PARQUET-2070
> Project: Parquet
> Issue Type: Improvement
> Reporter: Svend Vanderveken
> Priority: Minor
>
> This is trivial change, though at the moment ProtoWriteSupport.java is
> producing a human-readable JSON output of the protobuf schema with the
> following deprecated syntax:
>
> {code:java}
> TextFormat.printToString(asProto){code}
>
> Also, the method where is code is present executed one reflection invocation
> to get the protobuf descriptor which is unnecesserary since the context from
> where it's called already has this descriptor.
> => all minor and trivial stuff though well, housekeeping I guess :)
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
